fix: retry recovered credential decrypt failures - #700
Closed
Avilianb wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request has had no activity for 7 days. It will be closed in 7 days if there is no further activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credential_decrypt_failed.reauthRequiredcredentials in the bulk refresh candidate set.invalid_grant.Root cause
A temporary credential-encryption-key mismatch can mark a valid refresh token as permanently failed. After the correct key is restored, both manual and bulk refresh paths still stopped before attempting a refresh.
Validation
go test ./internal/application/account -run '^(TestCredentialRefreshFailureDistinguishesTransientAndPermanent|TestRefreshTokenRetriesRecoveredCredentialDecryptFailure|TestRefreshAllTokensRetriesRecoveredCredentialDecryptFailures|TestRefreshAllTokensSkipsUnrefreshableAccounts)$' -count=1go test ./internal/infra/persistence/relational -count=1was attempted, but an unrelated Windows temporary-directory cleanup error occurred inTestBuildSuperEntitledNonBuildForcedFalseafter the tests ran.